Chi Kei Chan

Results 10 comments of Chi Kei Chan

> Hi Jacky, > sorry that this never got merged. Would it be ok if I take the code parts with the tests of your PR manually and integrate into...

renamed to [signmessagewithprivkey](https://hsd-dev.org/api-docs/#signmessagewithprivkey) and [verifymessage](https://hsd-dev.org/api-docs/#verifymessage)

> I plan on reviewing this in depth but the first comment I have is this: I think we should try to limit Bob just to UI functions and keep...

> Are you sure we need all this work on the lookahead value? > I was hoping that if we merge #506 (bump lookahead to 200, still within the U8...

> Are you sure we need all this work on the lookahead value? So after more digging, I can confirm that there is at least one user wallet with a...

hello @pinheadmz - nice to see you active again! For this PR, the general changes to scan is: - wallet client will call `setFilter` with current height - wallet node...

specifying `cb` is already used to define whether the function is invoked synchronously or asynchronously. Changing it to following the standard `cb` pattern to return promises would introduce a breaking...

@aleybovich That works too! I will go with this approach

@whymarrh would love your opinion here - this PR add support for Promises, but the codebase uses es5 and browserify. Is it necessary to add `babelify` for promise polyfills? Since...

Yep. It seems that some unsupported datatype being passed to web worker.