Pierre Chifflier

Results 49 comments of Pierre Chifflier

Ok, 3 commits have been cherry-picked. As explained, closing the PR, please open a new one for anything new or to follow discussions

Hi, It seems you are mentioning two different issues: having access to the raw bytes, and wanting to serialize the certificate. Could you provide more details? There are no immediate...

I will have a look as soon as possible. The message itself is harmless, it only indicates a refill of the circular buffer, that is helpful to tweak the buffer...

Hi, Indeed, the record parser does not support partial messages, and at the moment the caller is expected to handle defragmentation of records (which includes messages) In the git repository,...

> Indeed, the caller cannot know whether the message is partial. Or we could keep the original API and record whether the message is partial in the returned structs. Is...

@traceflight just wondering, do you want to update your PR according to the last comments ? Or submit a new one, if you think this is more appropriate?

Hi, `pcap-analyzer` is complaining about the buffer size, which must be big enough for one block. Looking at the pcap file, this is caused by the first DSB block (block...

The correct changelog for 0.18 is (currently) in branch [x509-parser-0.18](https://github.com/rusticata/x509-parser/tree/x509-parser-0.18) files. That said, the files in branch `master` do not contain the correct information and need to be fixed.

Hi @cpu , thank you for the PR I am looking at it and intend to publish a new version today. Note: there is no tag `x509-parser-0.18` here, but `x509-parser-0.18.0`....