Pierre Chifflier

Additional notes: - the current preallocation is not exact anyway, since it allocates `count` *bytes*, not *elements* - not preallocating is a (weak) workaround. Allocation can still fail in some...

> @chifflier If you want to leave this un-merged I can push an update to add the matrix config from asn1-rs later tonight after I'm finished work. Otherwise I'll follow-up...

Perfect, thanks!

If you look at the CI annotation (failure in doc tests at src/der/parser.rs#L335), you'll see the lifetime problem explained above in `parse_der_implicit`, `parse_ber_implicit` and others: the `Header` would now be...

Hi @victorjulien Version 4.1 is quite old :/ For version 4.1, I think I can add a feature to enable/disable reexport of the macro. It would be enabled by default,...

So I just pushed 4d566f9ad602e21be23f40fbfdad55e6355efa3d which allows disabling the proc-macro causing problems. Hopefully this should fix the problem, but I guess there is no easy way to test before a...

Version 4.1.1 has be released, so I'm closing this issue. Feel free to reopen or open another issue if the problem is still there.

Hi, You're right on both points, I will fix this as soon as possible. Better code/example is available in the `pcap-analyzer` project: https://github.com/rusticata/pcap-analyzer/blob/f91f83ab03ea27a512873131abbc26130b8d0e85/libpcap-tools/src/block_engine.rs#L48-L101 Note on the referenced code: when an...

Hi @victorjulien , I believe the impact is limited: `rand` and `rand_core` are not really used by `tls-parser`, they are only used to generate a static hashmap of known ciphers...

Indeed, this issue can be closed since some time now.