Fabian Lichtenegger-Lukas

Results 12 comments of Fabian Lichtenegger-Lukas

Hi cloud-init community and maintainers, What do you think about such a feature? Any input is much appreciated! thx

> @chifac08 I'm assuming we'd add/remove any of the modules from `/etc/modules-load.d` depending on the `load` key, and that anything under the `modprobe` key would go into `/etc/modprobe.d`? > >...

@TheRealFalcon I was very busy the last weeks and wanted to make sure to have a stable version of my PR including unit and integration tests. Finally, I found time...

> Thanks, @chifac08, for improving cloud-init. > > The approach looks good overall. I left some inline comments, and I have a couple of generic ones: > > 1. At...

> Thanks, @chifac08, for the work here. > > Having a look into the failing integration tests, I have noticed some schema validation errors. > > tldr: > > ```diff...

> It looks great, @chifac08. A couple of minor things: > > 1. To render the new module doc, we need to include it in [doc/rtd/topics/modules.rst](https://github.com/canonical/cloud-init/blob/main/doc/rtd/topics/modules.rst). This is not documented...

@TheRealFalcon I would be delighted if you could review my PR. Thank you!

@TheRealFalcon @blackboxsw Current implementation is ready to re-review as i only implemented addressed changes. As already mentioned above, i would need some help if we want to make this module...

@blackboxsw thank you for your help and detailed explanation. I got an good overview about Distro classes and how to implement such a feature next time :). Would you mind...

Hi maintainers, Would you mind re-opening this PR? I really want to finish my work here and make sure it make it's way in the upstream. thank your for time!