ChickenchickenLove
ChickenchickenLove
I see! i reverted all and make new commits.
Thank you for your analysis a lot 🙇♂️🙇♂️🙇♂️🙇♂️! The logic remains the same eventually, but I think the direction you proposed is better because it gives `users` a choice.
I make new commit to apply your reviews. ```java default boolean ignoreEmptyBatch() { return false; } ``` I added `ignoreEmptyBatch()` to `RecordFilterStrategy` interface, and use it on `FilteringBatchMessageListenerAdapter` instead of...
@artembilan , thanks for your comments 🙇♂️ > We need some tests for this new feature. And, yes, I also think that this should go to 3.3 already . So,...
I added `spring-kafka-docs` as well to `Filtering Messages` section.
Hi, @artembilan ! long time no see 😄. Thanks for notifying me! I followed your comments about doing rebase and add description! Please take another look, when you have free...
Thanks for your time and looking this PR! Also, i will keep your advice in my mind and will do better next contribution 👍 Thanks a lot, again 🙇♂️
Hi, @artembilan. I'm interested in solving this issue. ```java if (consumerRecords.size() > 0 || consumerAware || (!this.ackDiscarded && this.delegateType.equals(ListenerType.ACKNOWLEDGING))) { invokeDelegate(consumerRecords, acknowledgment, consumer); } ``` Why we should consider `consumerAware`...
Thanks trustin nim. Thank you for taking the time to review this. 🙇♂️
Hi @ikhoon nim, orry to bother you. When you have time, could you take a look this PR? Thanks in advanced 🙇♂️