ChickenchickenLove

Results 30 comments of ChickenchickenLove

FYI, flow of `micro-meter/context-propagation`. 1. If we enable `context-propagation`, hook for `context-propagation` will be added `Reactor`'s hooks. 2. if `subscribe()` are called, hook like `captureThreadLocals()` are called. 3. and then,...

I investigate that internal of `Context-Propagation`. ### Case 1. `publisher.subscribe(...)`. `downstream -> upstream flow` - When `publisher.subscribe(...)` are called and `publisher` is instance of `ContextWriteRestoringThreadLocals`, it creates `ContextSnapshot.Scope`.in this sequence,...

@trustin nim, There are also major differences in the test. I would like to inform you about them. The test utility function `addCallbacks()` should be change. ```java private static Mono...

@trustin nim, There are two failed build list. - `build-self-hosted-unsafe-jdk-19-snapshot-blockhound`: `./gradlew: No such file or directory` error occurs. - `build-windows-latest-jdk-19` : because failed to upload Artifact. (403 Return) I think...

Thank you for taking the time to see me even on a holiday. I've learned a lot thanks to you. 🙇‍♂️

> Left a couple more super nit comments, still looks good for merging 👍 @jrhee17 nim, thanks for your review. When you have free time, please review again 🙇‍♂️

> Re-requesting review sounds like a bug. > https://github.com/line/armeria/actions/runs/8796330970/job/24138993146?pr=5547#step:2:10 > It seems that component-owners plugin takes the case into account though. > https://github.com/dyladan/component-owners/blob/cdaadffde64c918909ee081e3fe044b8910f56c2/src/main.ts#L64-L65 @ikhoon nim, Thanks for your comment. By...

@trustin nim, thanks for you to notify me 🙇‍♂️ I made new commit to resolve conflict. I guess this [PR](https://github.com/line/armeria/pull/5628#issuecomment-2098401460) cause the conflict. 🤔 I updated the PR description as...

I am investigating whether I can resolve this issue on my own. However, it seems currently unachievable due to the limitations of `KafkaTestKit`, which is used to create `EmbeddedKafka`. I...

@sobychacko, @artembilan thanks for you guys comments. I didn't know about `@EmbeddedKafka(kraft = false)`. i'm going to try to test it ASAP. 👍 This is [issue](https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-16648?filter=reportedbyme) which i reported. I...