Chun-Hung Hsiao

Results 7 comments of Chun-Hung Hsiao

Is this going stale? I'm currently using go-github to parse issue comments for pull requests but considering to add such support for go-scm. Is the intention of this PR to...

@bradrydzewski Could you provide some feedback about this? Thanks.

An alternative to avoid the breaking change is to use `req.Context()` as the context to reach out to the API endpoint. However that means if the caller want to interrupt...

The idea of a `normalize` package is neat. However, either the library requires the user to always use the package, or the webhook struct needs to have some indicator for...

What I mean is that, say any `PullRequestCommentWebhook` from github always requires a normalization, but no normalization is needed for gitlab. Since the user shouldn't care about what the underlying...

I recently had the same question and ended up essentially did the same as @thockin with [github.com/imdario/mergo](github.com/imdario/mergo): ```go // Make a copy of want so we can merge ignored fields...

Another snippet to use in combination with the time transformer to correctly compare KRM object statuses (before https://github.com/imdario/mergo/pull/222 is merged): ```go // The following function allows deep-merging slices (e.g., []metav1.Condition)....