Paweł Bylica
Paweł Bylica
Temporary but for long time :) Updating MTP seems quite a work and we only need this for testing. Because the state in the final block is evolution of all...
> I think at least since Prague, as block hashes are saved into state, the wrong state changes cannot cancel out easily. Hm... now I noticed this is weird: we...
Not needed for now so put on hold.
This is clang compiler issue. GCC compiles this fine and executes the test in 0.5s.
I plan to enable this for `MOD` too so don't merge yet.
I never wanted to merge this. This is my work in progress conversion TODO list.
> Perhaps error out of invalid test? How exactly?
We may get a protection against this in EEST: https://github.com/ethereum/execution-specs/issues/1500. But it may also break goevmlab fuzzer (cc @holiman). However, they may use `"blockHashes"` to provide the value for `BLOCKHASH(0)`.
> What do you mean "deprecated feature" - since the opcode `BLOCKHASH` is still not deprecated, what is a node supposed to do on that opcode, when executing a statetest?...
> Why do this? It bothers me this is mixed with the semi-production ready code. I'd prefer returning null hash but I think we can find a place for the...