execution-spec-tests icon indicating copy to clipboard operation
execution-spec-tests copied to clipboard

[DON'T MERGE] Machine-converted EOF validation tests

Open chfast opened this issue 11 months ago • 2 comments

🗒️ Description

🔗 Related Issues

✅ Checklist

  • [ ] All: Set appropriate labels for the changes.
  • [ ] All: Considered squashing commits to improve commit history.
  • [ ] All: Added an entry to CHANGELOG.md.
  • [ ] All: Considered updating the online docs in the ./docs/ directory.
  • [ ] Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • [ ] Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • [ ] Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • [ ] Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

chfast avatar Feb 03 '25 11:02 chfast

My only comment about all of these tests is that, the more Container(raw_bytes="... tests we have, the more manual refactoring we will have to do if some of the nice-to-have (e.g. data section type 0x04 -> 0xff) changes are approved for Osaka.

So I think we could limit adding these to only adding the ones that are really bumping the coverage IMO.

marioevz avatar Feb 05 '25 17:02 marioevz

I never wanted to merge this. This is my work in progress conversion TODO list.

chfast avatar Feb 05 '25 18:02 chfast