James Le Cuirot comments

Results 393 comments of


                                            James Le Cuirot

Drop the setter methods cache in favour of respond_to? (see #472)

I'm leaving the company soon and I'd like to get some (or all!) of these merged before I go. This one seems like a good start.

Drop the setter methods cache in favour of respond_to? (see #472)

One week to go. :stuck_out_tongue:

Scopes on associations

I was hoping this would work for custom_get (which are kinda like server-side scopes) but it doesn't because of this bit of evilness in the scope method. ``` ruby #...

Scopes on associations

@edtjones, if you're looking at this one, I'd really appreciate having a chat with you about it.

Scopes on associations

I'd like it to work more like it does in Active Record, where you can call any class method through an association. The code I quoted above highlights the difference...

Use nested path parameters from the parent when using build

Rebased.

Use nested path parameters from the parent when using build

I've rebased this, refactored it slightly, and added a much-needed caching feature. I was surprised it didn't do that already.

Use nested path parameters from the parent when using build

By caching, I mean that it sets the associated record using the setter method and by extension the `@_her_association_foo` instance variable that is already used for caching. Calling `bar =...

Use nested path parameters from the parent when using build

I've realised that my understanding was a little off before. `@_her_association_foo` is not used to cache the resource itself but the proxy. The fact that associations do not currently define...

Use nested path parameters from the parent when using build

I just about had things working nicely until I realised it breaks with `request_new_object_on_build true`. I am repeatedly being bitten by the fact that Her stores association data in the...