James Le Cuirot comments

Results 393 comments of


                                            James Le Cuirot

#where returns WhereChain when block returns an association's sifter (Rails 4)

@benebrice Are you using AR 4.1? I think that's the error I saw before I started making changes.

#where returns WhereChain when block returns an association's sifter (Rails 4)

@benebrice Nah, that version should work fine. It's 4.1 that's broken.

#where returns WhereChain when block returns an association's sifter (Rails 4)

Just ran into the original issue reported here myself. It's hard to see what's going on because there's a lot of voodoo in Squeel but it's definitely not calling `visit_Squeel_Nodes_Sifter`...

Implemented attribute_changed_in_place? on models so validates_numericality_of validation will work

I've run into this but I'm not sure about this change as I think `attribute_changed_in_place?` is meant to detect changes to mutable objects that would not be visible in the...

Return an empty collection when where(:foo => []) is given

Rebased.

Return an empty collection when where(:foo => []) is given

Rebased again.

Return an empty collection when where(:foo => []) is given

And again!

Proposed solution to issue #224, getting the expected request_path when ...

I'm not sure that this is such a good idea. Having an association doesn't necessarily mean that the parent path should be prepended like this. It really depends on the...

Proposed solution to issue #224, getting the expected request_path when ...

@edtjones, if you're looking at this one, I'd really appreciate having a chat with you about it.

Drop the setter methods cache in favour of respond_to? (see #472)

Rebased. I think this one is particularly important and it stands alone from my other remaining changes.