Jonas Große Sundrup
Jonas Große Sundrup
> This is needed because Range doesn't support partial lines, right? Aye, exactly this. @justinmk So simply rename Selection to Region you mean? Would make sense to further abstract from...
> Probably Range could be deprecated then, too. Actually, another reason to not deprecate Range would be that it would make perfect sense for a Range of three lines to...
Ok, Code ready for merge now. There are some complaints of flake8 left causing the CI to fail, but they do not affect those parts of the code that this...
@bfredl You might also want to take a look as we briefly discussed this in IRC.
@bfredl @justinmk Do we do something about the failing flake8-check in this PR?
ok, then I'd say this one is ready to be merged.
Thinking about this, I think I'll introduce a `BlockRegion` in addition to a normal `Region`, distinguishing e.g. standard visual selection from visual block selection. As this would be two types...
> They both are defined by a pair of (row,col) tuples. Actually not: standard visual mode has full lines between the first and the last lines and partial lines in...
Good point indeed. I'll reconsider the implementation and see how to merge both objects.
Based on the suggestions of @justinmk I redesigned the API for the Region object and it is indeed much more general now. I still like to rebase onto master, but...