cherry-1729-9090

Results 10 comments of cherry-1729-9090

> Have we done any further testing of CLN rebalancing? If it's not reliable, we should undo the changes for it and disable the functionality. > > Curious to hear...

Old UI : ![WhatsApp Image 2025-04-04 at 00 55 04_f0bc896d](https://github.com/user-attachments/assets/db224e6c-93bf-4e36-8a98-86672bfe8c68) ![WhatsApp Image 2025-04-04 at 00 55 13_b3e48389](https://github.com/user-attachments/assets/074cf354-93da-4339-9f91-4b5027d1ee47) The new UI for both Sign and Verify Pages to those implementations which...

@kaloudis, thanks for your feedback! I'll remove the address type from the dropdown as suggested. Regarding your idea for a separate view for address selection—similar to the Coins view—could you...

https://github.com/user-attachments/assets/d0b8d655-cf7e-47d4-a7cf-b48435aade7a @kaloudis , please take a look at this flow, I made a separate component for Address selection.

@kaloudis @shubhamkmr04 I've attached a video demonstration of the search and filter operations in the address picker as you suggested: https://drive.google.com/file/d/1KalGPpuWzJxytW4ABvjnY2X1te0wN5tt/view?usp=sharing I've successfully rebased my branch as requested to remove...

@kaloudis, I've now properly rebased and squashed my changes into a clean commit structure. The PR now contains only my 3 commits related to the message signing feature. I had...

@shubhamkmr04 @kaloudis Thanks for the feedback and guidance ! I have resolved the conflicts and now the branch and PR is clean. Here is the demo of AddressPicker after making...

@kaloudis Thanks for the feedback !, I've seen how the different backend implementations handle pubkey formats for on-chain address signature verification. I'll implement the changes to show the verified address...

> > > > > let's change the background of generated signature > > @cherry-1729-9090 @shubhamkmr04 After the previous review I have changed the background color to secondary theme color....

@shubhamkmr04 ![image](https://github.com/user-attachments/assets/82660d92-0004-4166-92f5-406ef9edd4f9) Can you please check whether this is the expected UI for selected address ?