Eric Chen
Eric Chen
Currently the test workflow (GHA) only support python versions 3.9 to 3.11, need to add 3.12. I tried to add 3.12 recently and found a build issue, need more investigation.
We adds support to benchmark data that includes top-level objects for JSON and CBOR. Need investigation for protobuf too.
Currently, benchmark-cli is able to benchmark data that includes multiple top level objects when `io-type=file`. We should enable this for `io-type=buffer` too. Reference PR - https://github.com/amazon-ion/ion-python/pull/315
Currently, build test on windows doesn't support python 3.8, it throws below exception ``` Run python3 -m venv ./venv Error: [WinError [2](https://github.com/amazon-ion/ion-python/actions/runs/6963159507/job/18948248057#step:5:2)] The system cannot find the file specified Error:...
When running below on the GHA Windows runner. ``` python ./amazon/ionbenchmark/ion_benchmark_cli.py compare ./tests/benchmark_sample_data/compare/cats_baseline.ion ./tests/benchmark_sample_data/compare/cats_baseline.ion --fail ``` It throws ``` UnicodeEncodeError: 'charmap' codec can't encode characters in position 0-64: character maps...
It would be good to do more investigation on below items: 1. For the source distribution, we now distribute c binaries to PYPI too but the script will clean them...
Some customers found that the lack of documentation makes them really hard to onboard Ion. This GH issue will be used for discussing a long-term solution.
#### Description: Specifically, `item()` and `iteritems()`. The original conversation is available in https://github.com/amazon-ion/ion-python/pull/284#discussion_r1319185416. In details, in Python 2: ``` dict.items() Description: Return a **list** of the dictionary's (key, value) tuple...
Currently, orjson is removed from ion-python-benchmark-cli due to pypy incompatible. Need to add it back later.
The benchmark-cli's performance detection workflow fails if the performance regression exceeds the threshold value. Currently, the threshold is set to 1, meaning that the workflow only fails when the new...