ion-python icon indicating copy to clipboard operation
ion-python copied to clipboard

Published 20 hours ago • verified publisher icon amzn

C extension distribution enhancement

Open cheqianh opened this issue 3 years ago • 0 comments

It would be good to do more investigation on below items:

  1. For the source distribution, we now distribute c binaries to PYPI too but the script will clean them up during installation (which means that they are not used, but are uploaded to PYPI due to the release process). It would be good to find a way to NOT distribute binaries to PYPI but build these binaries after installation and include them in the final directory.

  2. Using git clone instead of git submodule, figure out why submodule doesn't work during installation.

  3. We use string conversion for Ion int/decimal for now since Windows require a VS C++ build tool which otherwise raise errors. In addition, using string conversion is faster than math conversion after benchmarking. Refer to this commit for math conversion.

cheqianh avatar Jan 20 '22 01:01 cheqianh