Sam Chen

Results 84 comments of Sam Chen

Here's the one causing problem https://github.com/terkelg/tiny-glob/blob/master/index.js#L34, I can remove it, and everything works as expected in my case. Also, it won't fail any tests.

I just put up a failing test here https://github.com/chenxsan/tiny-glob/commit/18f54bc003973335915f333ec0ab841ef2c82c71

Here's benchmark result after I removed that line: ``` glob x 13,438 ops/sec ±3.05% (83 runs sampled) fast-glob x 25,485 ops/sec ±5.20% (76 runs sampled) tiny-glob x 55,162 ops/sec ±6.97%...

Here's the `lexer` variable: ``` { regex: /^(post|page)\/((?:[^\/]*(?:\/|$))*)([^\/]*)\.md$/, segments: [ /^(post|page)$/, /^((?:[^\/]*(?:\/|$))*)$/, /^([^\/]*)\.md$/ ], globstar: '/^((?:[^\\/]*(?:\\/|$))*)$/' } ``` And part of my directory structure: ``` $ tree ./post ``` ![image](https://user-images.githubusercontent.com/1091472/44962345-4b93f680-af51-11e8-9648-ba86937f34a3.png)...

Those're chinese characters. But I don't think it matters. Folders with english names like `firefox-os` are ignored by glob too.

@terkelg Thought it's really difficult for you to understand my situation, I just created a new repo here https://github.com/chenxsan/tiny-glob-demo. Please run `npm install` to install deps then run `node index.js`...

> Just note - `webpack@5` support workers (web workers and Node.js worker threads) out of box, you don't need this loader, it was deprecated someday (need improve docs) > >...

@alexander-akait I've created an issue to track it.

I just wrote a plugin here https://github.com/chenxsan/copy-optimized-svg-code, you can copy optimized svg code with it :)

@a5node I've filed a pull request to catch a similar failure, it seems they've deployed the fix to the production, maybe you can try again to see if it fixes...