Chris Hennes
Chris Hennes
It sounds like this still doesn't quite compile against VTK 9.4, so I'm leaving it so the changes can all be made at once. If you'd prefer to just merge...
You are importing gui code from the CLI version?
I've merged in @3x380V and company's work from https://github.com/3x380V/FreeCAD/commit/02cb8c41c687403c2f0e6decc16a2b09cda90353 -- I think once this passes CI it's good to merge, but feel free to double-check me on that.
@yorikvanhavre this is now ready for your re-review.
@AIRCAP can you take another look and see if it's working now?
@Syres916 can you tweak this to use C++ instead of C? I don't like seeing `strcmp` in new code.
The CI is being strange here, can you squash and rebase?
Update: we now have a FreeCAD-org fork of the original Ondsel repo: https://github.com/FreeCAD/OndselSolver
I'll look in a minute. Meeanwhile, the Windows pixi CI failure is a build failure ``` Error: D:\a\FreeCAD\FreeCAD\src\Base\Reader.cpp(166): error C2244: 'Base::XMLReader::getAttribute': unable to match function definition to an existing declaration...
I added a commit that makes this compile on MSVC. You aren't going to love it. I don't know what it will do on other compilers (probably fine???). Found by...