Chris Hennes comments

Results 699 comments of


                                            Chris Hennes

Use packit to build rpm and add it as check on pull request

@adrianinsaval do we already maintain a team Fedora account for this sort of thing?

Use packit to build rpm and add it as check on pull request

My plan is to create a fedora account specifically for this process -- but of course I chose to start that during a Fedora datacenter migration! So there will be...

Use packit to build rpm and add it as check on pull request

Well, I cannot activate our fedora account: I just keep getting an error during the final account creation stage (setting the password), with the very informative error message "Something went...

Use packit to build rpm and add it as check on pull request

Thanks, email sent.

Use packit to build rpm and add it as check on pull request

/packit build

Use packit to build rpm and add it as check on pull request

Ok @filippor I think this is working now: can you double-check the results before merging?

Use packit to build rpm and add it as check on pull request

Yes, the test that was previously called `Tests_run` has been split and renamed to `App_tests_run`, `Base_tests_run`, `Misc_tests_run`, and `Zipios_tests_run` -- the original name was misleading, it doesn't run all tests,...

LibPack 3.0.0 does not support building in DEBUG mode

> Would it be preferred to make a similar change to the `Debug` configuration when building on Windows? To which build? Of FreeCAD?

LibPack 3.0.0 does not support building in DEBUG mode

Right -- for 95% of debugging, RelWithDebInfo is really what you want to be using on Windows, but for that last 5%, it would be nice to have a full...

Activate directories for pre-commit hook

> I believe precommit does line endings too With our current configuration, it cleans line-endings on a per-file basis. So it makes a given file use the same endings throughout,...