Chris Hennes

Results 699 comments of Chris Hennes

@kadet1090 we know your joy at rewriting PRs, etc. so leave this for you to decide whether to address the "smol" issues...

I'd be a bit hesitant to call these "contracts" considering the ongoing work in the C++ standards community to implement [Contracts](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p2900r3.pdf) within the language. Do Gamma _et al._ have a...

That's a lot of buttons. Probably about time for a redesign, @FreeCAD/design-working-group.

@tarman3 can you take care of moving that button as part of this PR? Do you need help with it?

@FEA-eng can we live without that UI change for the 1.0 release? We are well past the UI strings lock deadline.

@marioalexis84 maybe I didn't understand your meaning -- are you still working on this PR? Or is it ready to go in?

OK, thanks -- I switched it to draft so it doesn't get merged accidentally.

Is there a new class here that is not being exported?

Thanks for the PR, @Beep6581 -- I haven't looked, does FeatureHole have any tests? This seems like a regression that we should add some checks for.