Chris Hennes

Results 699 comments of Chris Hennes

Can you fix the Ubuntu 20.04 build failure? @xtemp09 posted the solution above: > ```c++ > /home/runner/work/FreeCAD/FreeCAD/src/Gui/Splashscreen.cpp: In member function ‘virtual void Gui::Dialog::AboutDialog::copyToClipboard()’: > /home/runner/work/FreeCAD/FreeCAD/src/Gui/Splashscreen.cpp:896:12: error: ‘screen’ was not declared...

@yorikvanhavre is going to fix that compilation bug and get this merged.

Sorry, turns out `screen()` was introduced in Qt 5.14, so it won't work on 5.12.

I guess we can probably patch OpenCASCADE to fix it though, right? It's not intentional on their part?

@benj5378 it looks like @adrianinsaval has some unresolved comments above.

@Syres916 much as I hate `strcmp` and really, _really_ hate to see it in new code, in this particular case the new code is part of a chain of `if`...

Just for the record: with Qt6 on Windows 11, this PR makes the Start screen look fine in both Windows Light and Windows Dark themes, regardless of which FreeCAD theme...

You're giving me too much credit (or blame 😁). Werner added the `fileCardStyle()` stuff, I was only responsible for the underlying widget structure. I originally designed it as an experiment...

@kadet1090 is going to update to use a `dynamic_cast`