Chris Hennes

Results 699 comments of Chris Hennes

@PaddleStroke or @AjinkyaDahale do you have a few minutes to weigh in on this PR?

Nice. Let's add a `NOLINT(readability-magic-numbers)` -- IMO in test cases "magic numbers" are completely acceptable.

@benj5378 right now we are struggling to keep up with the 1.0 milestone PRs. Hold tight, we will get back to our normal PR process as soon as we can.

@davesrocketshop is going to give it a look

Still waiting on a comment from @benj5378 so this can wait in the queue until next meeting.

Still waiting on @sliptonic to have time to look at this, thanks for your patience @tarman3.

For the record, we don't do it for any other URL - they all work without the .php, but if you explicitly specify the extension, it remains.

We are already throttling `f3d` so it's a simple change to decrease the max size it will consider -- I hate to make it yet another user parameter, though. I...

> I agree with the author of this issue. What if the files are 500 MiB each? I used to open STL files about this size. We currently limit the...