Chris Hennes

Results 699 comments of Chris Hennes

This looks like it is still a work-in-progress, so I'm going to switch it into Draft mode. When you feel like it's ready to go, please switch it back. Thanks!

I don't see anything obvious -- we are at 5.0.0 on FreeCAD Main, so it can definitely be made to work. Did you see anything in `/home/gael/.cache/pre-commit/pre-commit.log`?

> Where can I see which version of `pre-commit` Github is using? We can add the following to the YAML file: ``` - name: Check pre-commit version run: pre-commit --version...

The error from an MSVC build with PCH enabled is: ``` [340/6479] Building CXX object src\Base\CMakeFiles\FreeCADBase.dir\PreCompiled.cpp.obj FAILED: src/Base/CMakeFiles/FreeCADBase.dir/PreCompiled.cpp.obj C:\PROGRA~1\MICROS~3\2022\COMMUN~1\VC\Tools\MSVC\1443~1.348\bin\Hostx64\x64\cl.exe /nologo /TP -DBOOST_CHRONO_DYN_LINK -DBOOST_CHRONO_NO_LIB -DBOOST_DATE_TIME_DYN_LINK -DBOOST_DATE_TIME_NO_LIB -DBOOST_DYN_LINK -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB...

Hi @davetanana, thanks for the PR, and welcome to the FreeCAD dev community! For future reference, you don't have to actually fill out the whole PR template, just delete the...

Since @kadet1090 is busy at work this month, and @3x380V is about to be out of the office for a month (wow, no computer or internet for a month sounds...

No, not Addon Manager: that file is in FreeCAD main: https://github.com/FreeCAD/FreeCAD/blob/main/src/Tools/doctools.py or more to the point, https://github.com/FreeCAD/FreeCAD/blob/c99cd73cd60874f231bda6233477e9051afcea57/src/Gui/DocumentRecovery.cpp#L72

We added a dependency on `defusedxml` in https://github.com/FreeCAD/FreeCAD/pull/24291 -- the fix here is probably to just switch to that (since the Addon Manager already has).

You are my new hero. This is a LOOOONG-awaited feature. Thanks!!

@MisterMakerNL do you have a minute to comment on the theme-ability of this search box?