Chris Hennes

Results 699 comments of Chris Hennes

This is looking good now -- is it ready for review?

Instead of removing the tests, could you modify them to cover `TimeElapsed`? It should basically be the same tests.

Yeah, if we can keep it to just a few ms that is fine.

Do you want to switch this PR to draft mode, then?

Didn't we have this same issue with another language on Mac OS? I recall looking into it, but not finding any obvious culprits.

Do you have time to check against 7.3?

@CalligaroV I just added it to the project

We probably won't worry about trying to use templates to simplify this code, but we probably will try to do something about the names of the move/moved/locate/located methods. Suggestions are...

@CalligaroV those suggestions sound good to me. @Pesc0 can you give that a try and see if it resolves the error you are getting? If it doesn't I'll try to...

As far as I can see, `owner` is never getting set -- so the first access of it segfaults. ETA: Your version omits the `TopoShape` that owns the `ShapeProtector`, you'll...