Chris Hennes
Chris Hennes
Thanks for the PR -- could you please address [the spelling errors that the linter found](https://github.com/FreeCAD/FreeCAD/pull/12404/files)? I'll review again after.
Looks like older OCCT doesn't have `History()` -- what version was it added in?
We currently support compiling with OCCT 7.3 -- so if there is something here that doesn't support that, we'll have to find a way to code around it (even if...
@maxwxyz it looks like you don't have pre-commit installed on your FreeCAD repo -- can you either do so, or manually fix the end-of-file complaints that the CI reported?
@obelisk79 Does anyone else from the DWG have an opinion on this change? It looks fine to me, but I'm not very picky about the default material.
I have no objection to toning down those highlights - @maxwxyz, what do you think?
Holding this until we release 0.21.3
(I'm switching this to Draft so we don't accidentally merge it while discussion is ongoing... please switch it to "Ready to Review" when it's solidified.)
I'm about to tear out QtWebEngineWidgets, so don't worry too much about that one 😄.
These AddonManager changes should be fine, all of those methods and constants existed in Qt 5.12.