Chengxiong Ruan

TFTR! bors r+

#83231 should be done before this

Though I don’t see what were the comment bugs and how they were fixed.

I don't know which project I should add to this issue...so I just attached my team.

@rafiss adding new keyword without adding to `bare_label_keywords` could break user query if the query use [column label without `AS`](https://github.com/cockroachdb/cockroach/blob/4753c67bfd92bc0c4823d1bb81b8ce25850f30bb/pkg/sql/parser/sql.y#L13967). Before `bare_label_keyword` was added, any new keyword could break user...

*[`pkg/sql/vars.go` line 2138 at r2](https://reviewable.io/reviews/cockroachdb/cockroach/85851#-N93mQPrBga4MecdHmS_:-N93mQPrBga4MecdHmSa:b-6awyb3) ([raw file](https://github.com/cockroachdb/cockroach/blob/1633901c4b5ee85e1419b04ed48f7bf72ab7b20b/pkg/sql/vars.go#L2138)):* > ```Go > return formatBoolAsPostgresSetting(evalCtx.SessionData().UserDefinedFunctionEarlyBinding), nil > }, > GlobalDefault: globalTrue, > ``` do we want a cluster setting as well so user...

> It feels to me like we should indicate somewhere on the descriptor whether or not it's late bound. I have a feeling we'll want to treat the references differently....

*[`pkg/sql/opt/optbuilder/create_function.go` line 49 at r3](https://reviewable.io/reviews/cockroachdb/cockroach/85851#-N997Tra3McCgKMm4jcN:-N9CF5zd569AZOnNBPPn:b-axkmsg) ([raw file](https://github.com/cockroachdb/cockroach/blob/ccd26475c81f398ff928d268310d36dd6c06ee4c/pkg/sql/opt/optbuilder/create_function.go#L49)):* Previously, chengxiong-ruan (Chengxiong Ruan) wrote… Yes, pg tracks user-defined types in UDF signature (argument types, return type) with whatever function body. an example:...

@michae2 thanks for the review! We still hesitate to do it. The reason is that turning this flag on and off and create functions with mixed behaviors might cause a...

> @chengxiong-ruan makes sense. If it's alright with you, I'm going to open an issue about late vs early binding, with some of the examples from the RFC discussion, so...