Christian Herz

Results 68 comments of Christian Herz

The thing is, that our SegmentStatistics get updated upon SegmentModified (which absolutely makes sense). The issue here is, that it would get called 11 times (11 segments). Maybe when displaying...

@lassoan Thanks! I will take a look into that. Regarding the StartModify() and EndModify() I think that should be done on side of SegmentEditor, right? QuantitativeReporting has nothing to do...

Interesting is also that when clicking `Show 3D` three times (show, hide, show) the number of `SegmentModified` and `RepresentationModified` events invoked ist unequal. When hiding the segments from the 3D...

> Simple show/hide shouldn't trigger SegmentModified. I'll look into this. Once the 3D surfaces are displayed and show/hide segments from the segment table view, no such events are invoked. Only...

@cpinter I just figured out, that no SegmentModified event is invoked when painting something. Is that on purpose?

It's https://github.com/QIICR/QuantitativeReporting/blob/5b820fbd030875eb81523d96c20af22d4f767d59/QuantitativeReporting/QRCustomizations/CustomSegmentEditor.py#L65-L69 and https://github.com/QIICR/QuantitativeReporting/blob/5b820fbd030875eb81523d96c20af22d4f767d59/QuantitativeReporting/QRCustomizations/CustomSegmentEditor.py#L146-L161

@fedorov Maybe this could also be interesting for the project week?

referenceImageGeometryRef is not set properly when loading from DICOM. Will look into that.

@fedorov When loading a segmentation into Slicer the user is required to select referenced series (if available) that will be loaded next to the segmentation into Slicer. Assuming that both...

@chribaue after talking with @fedorov about this issue, we think that duplicated measurements should be handled in SegmentStatistics. What do you think? Do you see a way to filter duplicates...