Christopher Dignam

Results 173 comments of Christopher Dignam

This seems doable. We can add an extra API call to `api.remove_label` where we set the "merge complete" status check: https://github.com/chdsbd/kodiak/blob/d2eb5d562622ba429621f26e1f844176e5b6fce6/bot/kodiak/evaluation.py#L1115 I'm not sure if this needs to be configurable...

@DmitriyNoa can you configure the Concourse status checks as required via GitHub branch protection settings? Kodiak will wait for all required status checks to merge.

It seems like we'd need to extract the URL from the body, make a request to it, then parse the compatability info from the SVG. I'm curious how reliable the...

I've deployed this change to production

Why do we raise ApiCallException for some errors but not others? https://github.com/chdsbd/kodiak/blob/b6b543d49acf8b019dcf2819f44d2a6774551bef/bot/kodiak/pull_request.py#L262-L268

Do you have the version SHA of Kodiak you were using? It looks like Kodiak isn't able to connect to the Redis instance. Can you verify that the Redis instance...

Thanks for looking into this. I'm don't think there's a good reason for using two separate connection pools

For the hosted version of Kodiak we have a large connection pool and do nightly restarts, which I think is why this bug hasn't been an issue for us. Is...

I think any time a connection is used in asyncio-redis, the connection should be wrapped with a context manager that will return the connection to the pool if there is...

Can you paste your Kodiak config? Also, can you paste a screenshot of your branch protection rules? Was the pull request's base branch deleted? Kodiak doesn't have logic to close...