Charlie Smith

Results 20 comments of Charlie Smith
trafficstars

It is private method `get_timezone` that has changed behaviour since pandas >= 0.24.0 https://github.com/man-group/arctic/blob/master/arctic/serialization/numpy_records.py#L84. This approach of invoking `get_timezone` has been since initial commit. ```python import pandas as pd from...

Requesting we merge and release this next week, as we are doing some internal testing with Python 3.8 that may uncover some bugs, and much easier to merge those in...

@CBeeson can you please review the above text changes? Also, could you please explain the reasoning for number 2? It was save because the review isn't technically completed till after...

Fix here https://github.com/faulkner/django-debug-panel/commit/a8bc8a28d1b9def22632cbdb40a488ce27654f0b , works with Django 1.10.1 and django-debug-toolbar 1.6

Actually, much easier to do it via the web gui. Best way to do code reuse is to create a new widget called `user-list` which will use `nominees-list` as the...

Tested this as of HEAD today (2020-04-05), this already works for external users that have been requested feedback. But we use the existing `enrollees` field to populate. Need to add...

For now, we will just create another table on the "Give Feedback" page which has just your team.

Hi @CBeeson, for this feature, specifically, the addition of teams, I think adding another column to the CSV called "team" would be the best approach. Reason is that it gives...

After discussion with @CBeeson, just use manager as nothing else in LDAP to group on, don't want to introduce another column as overhead for talent.

Fixed in feature-release-1 branch