Cian Hatton

Results 21 comments of Cian Hatton

Addressing the listed bullets: 1. As per @colin-axner's comment, we can leave as "ics20-1", I will add a comment to make this more explicit. 2. We will stick with using...

closing this as this work is not being actively worked on right now, and enough changes have been made to the E2Es that this test will not work as is....

@anhductn2001 once possible solution I can think of is to maintain a map of `chainPair -> relayerInstance`, this could require a refactor to the logic of the `startRelyerFn`, perhaps maybe...

Hi @anhductn2001, I tried running tests from `decentrio:restructure_e2e` and they seem to be running fine, which commands are you using to run tests that aren't working for you so I...

ah! @anhductn2001 that test specifically has an issue on main and is being worked on, can you try running a different test, maybe the transfer successful case `TestMsgTransfer_Succeeds_Nonincentivized` ?

Note: the defer telemetry statements are commented out the PoC, but should instead be refactored to account for multi denoms being received.

the structure of the tests has changed enough with the test suite level refactor that this issue isn't relevant anymore

Work was done in https://github.com/cosmos/ibc-go/pull/6029 that can be referenced when this is picked up again.

My vote: make all functions on keepers a reference. For state modifications it's not technically required, since different struct instances will be making changes to the same underlying store, but...