ibc-go icon indicating copy to clipboard operation
ibc-go copied to clipboard

E2E: Add scaffolding for rollkit E2E

Open chatton opened this issue 1 year ago • 4 comments

Description

closes: #5992

This PR Sets up scaffolding for a test which

  • deploys a celestia dev net
  • deploys a wasm simapp
  • deploys a rollkit app

Note: the underlying containers are deployed successfuly, but the E2E test will still fail due to interchaintest expecting ports to remain default, this can be addressed in a follow up.

Due to the nature of the test, some internal functions from interchaintest were copied over and used in order to do some lower level docker operations such as copying over private keys and manually creating a container (for celestia).


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

  • [ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
  • [ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • [ ] Code follows the module structure standards and Go style guide.
  • [ ] Wrote unit and integration tests.
  • [ ] Updated relevant documentation (docs/).
  • [ ] Added relevant godoc comments.
  • [ ] Provide a conventional commit message to follow the repository standards.
  • [ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • [ ] Re-reviewed Files changed in the GitHub PR explorer.
  • [ ] Review SonarCloud Report in the comment section below once CI passes.

chatton avatar Mar 20 '24 10:03 chatton

[!IMPORTANT]

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot] avatar Mar 20 '24 10:03 coderabbitai[bot]

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 20 '24 12:03 sonarqubecloud[bot]

@crodriguezvega I don't think we need to get this E2E merged into main until we have a working contract, I'll remove the priority tag, if you disagree feel free to re-add!

chatton avatar Mar 25 '24 13:03 chatton

should we maybe move this to draft too?

DimitrisJim avatar Jul 05 '24 08:07 DimitrisJim

closing this as this work is not being actively worked on right now, and enough changes have been made to the E2Es that this test will not work as is. We can use this PR as a reference when re-visiting this.

chatton avatar Aug 26 '24 11:08 chatton