Chase Starr

Results 52 comments of Chase Starr

I'm glad you are enjoying baseweb. Fixed columns on the data-table are not priority for our own uses at the moment, but please feel free to contribute the feature if...

Thank you for contributing this PR. I apologize, but landing this would require us to codemod a decent amount of internal code and we will not be prioritizing that effort.

Can you please give a more detailed description of your use-case?

Closing this in-progress pr to clean up the list. Please let us know if this is still an issue

Hmm I assumed that the `closeable` prop on `Modal` would do what you're looking for. https://codesandbox.io/s/modal-7khwy This looks like a regression that needs to be fixed

reopening because closing pr solved initial issue, but some improvements can be made. description here: https://github.com/uber/baseweb/pull/2686#pullrequestreview-347554259

Thank you for putting up this diff. We've added this feature here https://github.com/uber/baseweb/pull/5103

Thank you for the bug report @hhvys. I personally cannot reproduce this. If anyone else can, please share your reproduction steps

Closing this in-progress pr to prep for sync out switch