Chase Starr

Results 52 comments of Chase Starr

Thank you for contributing. We've updated rating star colors to black since this PR was opened. Please re-assess and open again if this is something we still want

Forked the repro sandbox and added some more debug information here https://codesandbox.io/s/base-web-formcontrol-forked-gewibh?file=/src/example.js

Closing this in-progress pr to clean up the list. Please let us know if this is still an issue

Thank you. I'll need to spend some time next week reviewing how this will affect our internal projects. As shown in this PR, some tests may need to change

We're likely not going to land this PR due to the disruption it would cause in our internal tests. Thank you for submitting

Can you please share an error you're finding?

We don't use typescript at Uber, so some issues may be found with those type definitions. Would you like to try contributing a fix?

Thank you. We can drop react v16 and set min to v17. Can you please update the package.json in this PR?

We've switched our internal react code to v18/TS and everything seems to be type-checking fine. Closing this in-progress pr to clean up the list. Please let us know if this...

Thank you for submitting this pr. I'd like to minimize this use-case and not provide a distinct example