Charlie Rudenstål

Results 3 comments of Charlie Rudenstål

Just speculating, but would it be possible to add these tags, without modifying `lightstep-tracer-javascript` itself, by setting up a Tracer that extends from the Lightstep Tracer and overrides the `inject`...

Looks like the `spanContext` is fairly limited: https://github.com/opentracing/opentracing-javascript/blob/master/src/span_context.ts What we need to access is the actual `span` (https://github.com/opentracing/opentracing-javascript/blob/master/src/span.ts). Perhaps it would be useful to have this feature baked into `lightstep-tracer`....

Wouldn't silencing with `|| true` also silence any errors if the script exist but fails? Imagine running a script like `test`, `test:e2e` or `lint`. There's definitely a use-case for exiting...