Charmander

Results 205 comments of Charmander

@jlaustill Why the split? The simple `date` type shouldn’t contain a `T`. But otherwise, yes, that (setting a no-op text parser of `String` or `x => x` for `date`) is...

It does already say: > - On Ubuntu/Debian: `apt-get install libpq-dev g++ make` Should we just add `python3` to that and mention that it applies to the Debian-based Node images...

It can’t just forward those things to `super()`, because the passed `destroy` would override the class’s definition of `_destroy`. I don’t think an option that overrides when the stream ends...

Not the same type of streaming: pg-query-stream uses cursors.

Is the `message` event on `Connection`s low-level enough for your needs?

The `message` event is only for incoming messages. You would add the event listener to each `Connection` object: ```js pool.on('connect', client => { client.connection.on('message', …); }); ```

> Are there situations where node-pg switches to binary protocol? I think queries accept a `binary: true` option? It also used to when a `Buffer` parameter was passed; not sure...

> Would using pg-native leverage the binary protocol? No, pg needs to parse and serialize between JavaScript values and binary representations regardless of whether it’s using libpq. > Parsing of...

I think the allocation they’re referring to is the additional `Buffer` view object itself on the string path.

All the pg packages follow semver. The changes in the main branch should be backward-compatible. (Of course, mistakes happen sometimes.)