Charmander
Charmander
Why does this one need `_checkPgPass` on top of `_handleAuthSASL`’s?
Does `_handleAuthSASL` not already take care of that? Can you give an example of a use of the library that behaves differently before and after this change?
Someone’ll need to write a test for this. I wonder what it does when `host` is a Unix domain socket?
@vitaly-t That doesn’t sound like the same issue; the host in that one isn’t an IP address, and the claimed behaviour is missing SNI, not certificate validation failure. @RazerM It...
@vitaly-t It looks like pg sets `servername` unconditionally, but we want to allow it to be overridden; working on a fix for that. (That should mean the SNI is the...
Of course it’s clear what’s wrong. That doesn’t mean it doesn’t need a test. It was able to break in the first place because there was no test. I can...
Also, #2653’s case can be a query error, same as if a type parser failed. It doesn’t need to be treated like a protocol error.
@Fangmingdu It hasn’t been fixed, but you can set `extra_float_digits` manually: https://github.com/brianc/node-postgres/issues/1393#issuecomment-319308021 > Should we be making this the default (i.e. extra_float_digits=3) vs making it an explicit setting? Yes, I...
> Does either example need an actual event listener for `error`[…]? […] I wasn't sure if it was actually possible for an error event to be emitted between say the...