kaml icon indicating copy to clipboard operation
kaml copied to clipboard

Initial implementation of Yaml*Serializers

Open pschichtel opened this issue 2 years ago • 2 comments

this is still very much broken and there a bunch of open questions, but this could be a viable starting point. This was basically adapted from the Json equivalents. The Json module seems to have more support for this in the Encoder/Decoder directly.

Someone with more knowledge of the inner workings of this module should have a look at this and also at the test failures I'm seeing.

The idea is to be able to decode and re-encode with these serializers and get the exact same value back, that's what the tests try to verify.

Since I'm switching over to a different approach for my project, I will not be needing this myself, so depending on how much work is left here I may not be able to continue working on this actively.

pschichtel avatar Jul 03 '22 18:07 pschichtel

Thanks for submitting this @pschichtel. Are you able to expand on the issues you ran into and what you think could be done to fix them?

charleskorn avatar Jul 05 '22 09:07 charleskorn

I'm not even sure if accessing the Input instances in the way I did is correct. In one case I seemed to receive a YamlMapInput where I would have expected to receive a YamlScalarInput.

I think if you run the unit test I added you'll see most of the issues I had

pschichtel avatar Jul 06 '22 09:07 pschichtel

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. It will automatically be closed if no further activity occurs in the next seven days to enable maintainers to focus on the most important issues. If this issue is still affecting you, please comment below within the next seven days. Thank you for your contributions.

stale[bot] avatar Sep 04 '22 10:09 stale[bot]

This issue has been automatically closed because it has not had any recent activity.

stale[bot] avatar Sep 11 '22 10:09 stale[bot]