Charles Cooper

Results 415 comments of Charles Cooper

the check in `get_target` is never supposed to be tripped (`TypeCheckFailure` is classified as a kind of panic), but yea we should probably update

partially addressed in https://github.com/vyperlang/vyper/pull/4157

maybe instead of dynamically creating the class, we can have `BlockEnv` inherit from something like `MagicAttributeSet`?

also i think if we are going to do this we should plan to do it for everything in the patcher.

the gas stats not appearing is a drawback of the table renderer, they just get lost if there is truncation. we should also export the gas results to csv or...

btw, i think public variables not appearing is a bug in vyper's source map generation, which should have been fixed in 0.4.0 (https://github.com/vyperlang/vyper/commit/a91af13db9d6d89e6c2139c1b28c490845f06e13 if i'm not mistaken). can you try...

this seems like a good feature to have but i'm not sure if we want to add dependencies willy-nilly. maybe we can add it as an extra? @DanielSchiavini

it's mainly just useful for etherscan at this point, although theoretically it could also do caching for other web requests (like the RPC stuff). we could also use the `boa/utils/disk_cache.py`...

superseded by 4e3d56c6f2b1c10c10cba9b14fb209036ffc7081