titanoboa icon indicating copy to clipboard operation
titanoboa copied to clipboard

wip - add requests_cache

Open charles-cooper opened this issue 10 months ago • 2 comments

What I did

How I did it

How to verify it

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

charles-cooper avatar Mar 28 '24 17:03 charles-cooper

this seems like a good feature to have but i'm not sure if we want to add dependencies willy-nilly. maybe we can add it as an extra? @DanielSchiavini

charles-cooper avatar Mar 28 '24 17:03 charles-cooper

it's mainly just useful for etherscan at this point, although theoretically it could also do caching for other web requests (like the RPC stuff).

we could also use the boa/utils/disk_cache.py thingy to implement caching by hand. so it's a tradeoff between reinventing stuff and adding dependencies. my concern about adding it as an extra is that the standard advice/setup will be "install boa with the requests_cache extra" and then it will be de facto the same as putting it in the required dependency list, but i'm not too sure on this one.

charles-cooper avatar Apr 02 '24 13:04 charles-cooper

superseded by 4e3d56c6f2b1c10c10cba9b14fb209036ffc7081

charles-cooper avatar Oct 05 '24 00:10 charles-cooper