Charis Rafailidis

Results 11 comments of Charis Rafailidis

> Having a top-level await can be tricky and not supported in older environments. How to account for those that can't support that? I mean I'm just stating the problem,...

Note to reviewers: I created ~~https://github.com/smlxl/evm.codes/pull/317~~ https://github.com/smlxl/evm.codes/pull/318 to take over from this branch. I took care of as much PR feedback as I could there, put comments where needed above...

> > Note to reviewers: I created ~~#317~~ #318 to take over from this branch. I took care of as much PR feedback as I could there, put comments where...

Superseded by https://github.com/smlxl/evm.codes/pull/318

Superseded by https://github.com/smlxl/evm.codes/pull/318

@developerfred all you need to for the to fix the build error is replace this: ``` children: [ 'theme-light', 'theme-dark', 'theme-system' ], ``` with this: `children: ['theme-light', 'theme-dark', 'theme-system']` in:...

> Thanks @2xic @dorlevi and @charisra build working now > > version working [evm-codes-fmjmeuoa2-developerfred.vercel.app/transactions](https://evm-codes-fmjmeuoa2-developerfred.vercel.app/transactions) It's lot letting me preview so can't tell if it's ok @developerfred . I still see...

> @charisra My commits were compiled, I also used prettier, what are the next steps? Great. I'll review once more, also check the Preview, approve and then you can merge.

So that's what I'm expected to see? Just the types, there's not any more info on those, it mentions `There is no reference doc for this yet. Why not contribute`...

@developerfred I approved the PR. Is there anything pending before you merge?