Chris Chan
Chris Chan
I'm unsure how to fix the unittest as it passes for me locally: ``` ➜ ruff git:(PLR0915) cargo test rules::pylint::tests::max_statements Finished test [unoptimized + debuginfo] target(s) in 0.84s Running unittests...
> Can't for the life of me figure out that failure. Going to try downgrading `insta` I guess? I think I figured it out, I put the wrong path inside...
> The rule was added in #2550 but there's no conversation in that PR nor is there any change to the rule explaining if that divergence is indeed intentional. >...
You mind if I implement `too-many-return-statements`?
This case: ```python items = ["a"] # TODO class NotOk: __slots__ = items a = None ``` pylint does catch, is this something we can handle by using the deferred...
> Thank's for implementing the new rule. I'm trying to understand the rule, but I couldn't find any useful explanation. > Would you mind outlining why this specific pattern is...
> Thank's for implementing the new rule. I'm trying to understand the rule, but I couldn't find any useful explanation. > Would you mind outlining why this specific pattern is...
> This case: > > ```python > items = ["a"] # TODO > > > class NotOk: > __slots__ = items > a = None > ``` > > pylint...
Thanks for the feedback, sounds good! I've not been as free as I'd like but I'll come up with something on the weekend.
Sorry I took so long to getting round to having a stab at this. Do you think it would make sense for me just to return the `Located` Import and...