Alexandre de Champeaux comments

Results 5 comments of


                                            Alexandre de Champeaux

ObjectProxy does not play well with GenericAlias, such as isinstance(proxy, Dict)

Hey Graham, So, for Dict, it is coming `from typing import Dict`. The code I'm referring to is [here in `typing.py`, L1164](https://github.com/python/cpython/blob/d0160c7c22c8dff0a61c49b5304244df6e36465e/Lib/typing.py#L1164) I also just found this ticket in CPython:...

ObjectProxy does not play well with GenericAlias, such as isinstance(proxy, Dict)

I think @pbryan argument is fair enough. I think as long as this happens in code I own / have control over this is pretty easy to fix / handle...

ObjectProxy does not play well with GenericAlias, such as isinstance(proxy, Dict)

...... Twitter.... Some devs seem to agree there if I understand correctly https://github.com/python/cpython/issues/89949 . Also not sure how much it actually matters, and it may be a dangerous change

ObjectProxy does not play well with GenericAlias, such as isinstance(proxy, Dict)

Thanks for the help. Looks like I will have to be careful using the proxy. It seems that CPython's [`PyTuple_Check` checks the type and not the class](https://github.com/python/cpython/blob/c780698e9b8416633402657ee2846c0179705e9b/Include/tupleobject.h#L26C9-L26C22). This causes issue...

gather_sources_and_dependencies fails in notebooks with ipykernel 6.21.0

I'm guessing that the difference is that I'm running in jupyterhub. Or do you have `__file__` that is defined, and that also exists according to `os.path.exists(__file__)`?