Matteo Ferrando comments

Results 95 comments of


                                            Matteo Ferrando

Output appears in "Captured stderr call" but is unavailable in capsys or capfd

I am wondering what happend with this @asottile ?

Output appears in "Captured stderr call" but is unavailable in capsys or capfd

I understand. turning off the syscapture part maybe does not really make sense and this needs a different solution?

Add directive to specify if a shift or a reduce should be done in s/r conflicts

Although I can't think of where to put the directives to resolve a specific conflict.

Upgrading dbt-core from 1.5.1 to 1.5.2+ forces downgrade of dbt-fal to 1.5.4

We have a new strict check on dbt-core version because dbt-core 1.5.2 introduced breaking changes. We have to fix these before we can re open dbt-fal to 1.5.2+

ES6 classes support of virtuals

I think the solution is not actually the best. This assumes there is a `virtuals` object to clone (which in turn assumes the [virtuals plugin](https://github.com/bookshelf/bookshelf/wiki/Plugin:-Virtuals) is enabled?). Wouldn't it make...

Automatically serialize belongsToMany into relation meta attribute

So it's for `belongsToMany` relations. But the test I see in this PR talks about a `belongsTo` relation, should it be changed to `belongsToMany` then?

Automatically serialize belongsToMany into relation meta attribute

Actually, I haven't reviewed it yet! I tried to understand the feature with the spec and since I'm not entirely sure how pivot tables work I can't really review it...

Automatically serialize belongsToMany into relation meta attribute

Maybe rebase from master?

TypeORM Integration

I think I see your point with the idea of passing in a single type of `object` or `object[]` and do the ORM to JSON transformation in another. It can...

pivot (join) table attributes not included in response

Should they be added like `meta` attributes or as part of the normal `attributes`?