Patrice Chalin

Results 824 comments of Patrice Chalin

In https://github.com/jaegertracing/documentation/pull/988#discussion_r2437332445 @yurishkuro wrote: > > The linkTitle is currently being used to display the docs version > > In understand, but we could've derived it from file name. Or...

@nate-double-u - is `bulma` due for an upgrade? Might that upgrade resolve the issue this PR is trying to solve?

@martinkuba - pls rebase and resolve conflicts. Thx

FYI, also see the following related issue, which we should address separately from this PR: - #3760

This just came up in our meeting today. cc @RedBrogdon @galeyang @sfshaza2

What is/are the use cases that you have in mind? You recollection is correct and that has not changed, out-of-the-box, but I'm sure we can get it to work for...

Prep work that might be in support of version: - #6101

For the record, the paths are correct (refer to translations of the current page) for the Kubernetes website. But they've implemented their own mobile-only hamburger for the top-nav: e.g., visit...

> Thanks for your thorough review, all changes are incorporated, checkers are green. Great! Will get back to you as soon as I can for the next round of review.

> We can either backport my changes into v12.0 or we make a new release v12.1 We'll be putting out a new release (0.13.0) soon.