Robin Chalas

Results 310 comments of Robin Chalas

Can you try documenting the param explicitly the same way as the interface? It may be enough to avoid the notice.

Extending the public API is a feature (and as such implies to increment the minor version as per semver) so this would be for 6.2. But let's keep this on...

Ah, regarding https://github.com/symfony/symfony/pull/46428#discussion_r878912749 I don't feel like we should remove these extractors now that they are there, it's spec compliant after all. However maybe could we at least add a...

I second this, PHP config should definitely have recipe syncing work out of the box. I'm not totally sold with the multi-repository approach though as it would make recipe discovery...

@maks-rafalko Are you wiling to submit a PR that adds your middleware in core?

I agree it's too much of a hack :) Anyway, do we really want to put an attribute imported from the DependencyInjection component to all non-service classes? There's no plan...

👍 Sounds good to me. @tjaari Would you be motivated to work on this?

I'm going to look at this.