chaen

Results 91 comments of chaen

Hum, not sure I understand why travis has failed here. Any hint ?

Sigh... my eyes were caught by the red warning, and I did not see the most important :-) I will fix it. Thanks !

To be honest, saying that I have little experience with Tornado and its internals is an understatement :-). I agree that monkey patching is ugly and would love to get...

OK, I'll try to come up with something then

With the last commit, the monkey patching is not needed anymore. Does that look alright to you ? As for the `HTTPServerRequest` class, the issue here is that it does...

I've re implemented following what I proposed. Let me know if you think this looks more like the right way you expect

Fine with me. So just to make sure I understood properly: you're yet unsure whether we should modify `IOStream.start_tls` or just deprecate that ? If that's the case, I'm not...

Hum, I have no clue why one test failed on the pypy build, while it did not on all the others ```The command "LANG=C python $TARGET" exited with 1.``` Any...

Yes but I don't have enough karma to do it myself :(