Chad Dombrova

Results 167 comments of Chad Dombrova

> I could add to that file, but asking first: Are you set up to test in combination with an open pybind11 PR (https://github.com/pybind/pybind11/pull/4888)? No. But maybe there's an even...

I should add that if the annotation in the docstring parser could be tripped up by use of parentheses in the types: `Iterator[str, Annotated[Any, CppTypePybind11("cpp_namespace::UserType")]]`. Is this something that you...

`Annotated[Any, "cpp_namespace::UserType"]` is preferable to `Annotated[Any, CppTypePybind11("cpp_namespace::UserType")]` unless there is an actual importable python type called `CppTypePybind11`, in which case you should include the module name and the new version...

With regard to nesting, `Annotated` should wrap the type that represents `cpp_namespace::UserType`. @bluenote10 is correct that `Iterator` only takes one argument. So, if the `Any` represents the UserType, then this...

> ```python > def func_returning_array() -> List[float[4]]: ... > def func_returning_vector() -> List[float]: ... > ``` > > Similar function signatures, but note that the import for List is missing,...

Hi all, I'm back on this! I'm going to rebase onto dev, and see if we can get this merged. By the way, I've succeeded in moving my stub generation...

> Had a few nitpicks, but I think it would be ok to merge even if they're not addressed... @pmolodo, thanks for the review! Sorry it's taken me awhile to...

@hamdanal @JelleZijlstra This is ready for review.

Hi, does anyone have a moment to review this, please!