Chad Dombrova
Chad Dombrova
Hi all, thanks for flagging me. This is unfortunately an issue with PyCharm. `mypy` correctly understands that the type of `self.my_signal` is `SignalInstance`. I added a `reveal_type` statement and ran...
I think this is the relevant PyCharm ticket: https://youtrack.jetbrains.com/issue/PY-47698/PyCharm-does-not-know-recognize-return-types-of-custom-descriptors I made these stubs as accurate as possible, so that they would work with advanced code-bases using `mypy`. It's possible to...
@georgepsarakis I haven't implemented it yet, but for redis I'm hoping it's as simple as adding a pipeline with LTRIM to `redis.Channel._put` in the case that `max_length` is set on...
Here's a rough draft for redis: ```diff diff --git a/kombu/transport/redis.py b/kombu/transport/redis.py index 763b3dfa..9c03e20c 100644 --- a/kombu/transport/redis.py +++ b/kombu/transport/redis.py @@ -485,6 +485,7 @@ class Channel(virtual.Channel): self.ResponseError = self._get_response_error() self.active_fanout_queues = set()...
From my POV, the most important aspect of vendoring was -- and still remains -- site package isolation. Rez's python dependencies must be accessible only to the `rez` CLI --...
By the way, the policy and rationale for pip’s use of vendoring is probably relevant here: https://pip.pypa.io/en/stable/development/vendoring-policy/#
google style is fine with me, but the empty lines are required by the restructuredText parser (except for the last one).
sounds good.
I renamed this ticket from 'decide on...' to 'consolidate...' so that we can use it to track the progress of cleaning up our docstrings.
Here are some more complete examples of google-style docstrings: http://sphinxcontrib-napoleon.readthedocs.org/en/latest/example_google.html