Yourim Cha

Results 19 comments of Yourim Cha

Unlike text style, which stores nodes requiring style application in `toBeStyleds` using `latestCreatedAt` and adds changes only for those nodes, the tree style implementation currently lacks `latestCreatedAt`. - https://github.com/yorkie-team/yorkie-js-sdk/blob/8b6ae9788f1b33c52930aae885319a4841eb84b1/src/document/crdt/text.ts#L266-L292 -...

The current `ClientEvent` includes four events: `StatusChangedEvent`, `DocumentChangedEvent`, `StreamConnectionStatusChangedEvent`, and `DocumentSyncedEvent`. Upon reconsideration, it appears some places may still require these events. What do you think about the following modifications?...

This is implemented in https://github.com/yorkie-team/codepair/pull/235 🎉

I'm experiencing the same issue as well. Is there any progress on this? https://github.com/PlasmoHQ/plasmo/assets/81357083/fc8af519-284c-41b8-ada1-cc41315e993c

@krapie Yes, that seems necessary. Here's the discussion we had about what tasks need to be carried out regarding this issue, for your reference. https://codepair.yorkie.dev/community/65e02d3166a65e76f6703d15/share?token=2ij9re

@blurfx It seems I was a bit short on context in explaining the issue. In order to make devtools work only in the development build environment, I added the condition:...

@blurfx Thanks. Currently, to avoid this issue, we've changed Devtools execution to be determined directly by users setting true/false instead of checking `process.env.NODE_ENV`. (ref: https://github.com/yorkie-team/yorkie-js-sdk/pull/760) ```js const doc = new...

@blurfx Yes, I think it's still a good idea. Having devtools enabled by default in the development environment would likely make the development process more convenient. (The `enableDevtools` option would...

@hackerwins Thank you for your review. I've made the following modifications: > A. Lazy generating the operation bytes: Modified to build byte data from events only when devtools are enabled....

@blurfx, I agree. It would also be good to refer to the work that @easylogic previously attempted. #746