Chabbey François comments

Results 7 comments of


                                            Chabbey François

Fix 'child in a list should have a unique key prop'

Thanks @alexcjohnson for taking care of it. I've tried to fix this issue, but I realized that it was not as straightforward as I thought it would be, especially if...

Update package.json

Sorry for the typo, I've done it a bit too fast. Fixed

Duplicate trusted type policy error when using an angular app with a webcomponent that embeds an angular app

The issue is that, in the webcomponents ( here. https://github.com/angular/angular/blob/98575701658265dbf87512efbbf957c639033156/packages/core/src/util/security/trusted_types.ts) getPolicy() will always return null ( as the policy is already defined in the main app ), but trusted types...

Duplicate trusted type policy error when using an angular app with a webcomponent that embeds an angular app

@dylhunn Yes

Locales are now using .js extension, which breaks unit tests that are run with jest

That's a valid point. I'm just gonna play the devil's advocate. Basically we are in an enterprise setup with 50+ frontend repos whose CI pipeline suddenly stopped working ( but...

After updating static-asset to 3.x, excluded paths fallback to index.html ( instead of returning a 404 )

The root cause is the change of behavior of this method. It does not work anymore ( the regex returned by pathToRegexp has slightly changed ) https://github.com/nestjs/serve-static/blob/master/lib/utils/is-route-excluded.util.ts

After updating static-asset to 3.x, excluded paths fallback to index.html ( instead of returning a 404 )

Ok, after a few investigations, I think I've found the root cause serve-static is now using [email protected]. Before it was using the 0.1.7 version. The generated regex are not the...