Chance Strickland
Chance Strickland
Reviewed π’
Just going to drop a link to my thoughts in the other discussion to explain why I am opposed to this. My opinion mirrors much of what @kentcdodds has already...
@ryanflorence I hear what you're saying. As a PHP/WordPress alum, I have just always appreciated the commitment to back compat and truly believe that's a core pillar of what makes...
> That's always the case when changing APIs. Opt-in flag or dual compatibility in v1, deprecation warnings before v2, removal in v2. Right, I'm suggesting an opt-in flag or dual...
I don't think this should be stale, lil bot π€
Looks like this was shipped in 1.11, resolved in https://github.com/remix-run/remix/pull/5030. I'm going to close this but I'll add @ikarus-akhil to our contributors list since we dropped the ball on reviewing...
@brophdawg11 Just so it's on your radar, you probably want to keep the v1 compat package in sync with these kind of fixes. https://github.com/remix-run/v1-compat-utils
@MichaelDeBoey Ready to merge this if you're able to bring the branch up-to-date π
Looks like this has diverged a good deal since our current implementation of `unstable_parseMultipartFormData` moved to `@remix-run/server-runtime`. Closing for now, but feel free to open a new PR if the...
@nicksrandall I'd like to get this merged but there are comments left by @jacob-ebey that still haven't been addressed, and the server compiler code was moved into `compilerServer.ts` so some...